Inconsistant Zen Discovery Ping Timeout Documentation

[xyu]

Hello,

It appears there is some inconsistency with the setting of the ping timeout for zen discovery; some places it's referenced as discovery.zen.ping.timeout and in others it's discovery.zen.ping_timeout.

It appears a change was made to support ping.timeout in 9be62a0 which also exposed the setting in the sample config file. However the docs for zen refer to ping_timeout worse, it appears fault detection uses the ping_timeout name with no allowance for ping.timeout nor ping.interval, etc.

It seems like it would be more consistent to refer to the timeout value as ping_timeout in both the sample config as well as in the logs to avoid confusion.

[kimchy]

I totally agree, it is very confusing. Actually I think discovery.zen.ping.timeout should be renamed to discovery.zen.ping.gossip_window, or something along those lines. We should revisit those settings to make sure they are more readable.