Introduce Elasticsearch PostingFormat based on Lucene 90 positing format using PFOR #103601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Search/Search
|
Hi @iverase, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search (Team:Search) |
jpountz
reviewed
Dec 20, 2023
server/src/main/java/org/elasticsearch/index/codec/postings/ES812PostingsFormat.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/postings/ES812PostingsFormat.java
Outdated
Show resolved
Hide resolved
ChrisHegarty
approved these changes
Dec 20, 2023
jpountz
approved these changes
Dec 20, 2023
server/src/main/java/org/elasticsearch/index/codec/PerFieldMapperCodec.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/codec/postings/ES812PostingsFormatTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/codec/postings/ES812PostingsFormatTests.java
Outdated
Show resolved
Hide resolved
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Dec 20, 2023
…mat using PFOR (elastic#103601) Lucene 9.9 has introduced a new posting format that uses FOR instead of PFOR. Elasticsearch prefers the former format, therefore we introduce it as a our own posting format here.
|
A question about the 1st comment "Lucene 9.9 has introduced a new posting format that uses FOR instead of PFOR. Elasticsearch prefers the former format, therefore we introduce it as a our own posting format here." I think ES prefers the later format? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene 9.9 has introduced a new posting format that uses FOR instead of PFOR. Elasticsearch prefers the former format, therefore we introduce it as a our own posting format here.
fixes #103002