Skip to content

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Feb 29, 2024

Update Gradle wrapper to 8.7-rc-3

@breskeby breskeby requested a review from a team as a code owner February 29, 2024 16:00
@elasticsearchmachine elasticsearchmachine added v8.14.0 needs:triage Requires assignment of a team area label labels Feb 29, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I think this is a wrong at all as this project path never existed and it only didn't break the build by accident as gradle considers this a client module conjuration which is now deprecated. That line wasn't doing anything but now with gradle 8.7 triggers a deprecation warning which breaks the build (see https://docs.gradle.org/8.7-rc-1/userguide/upgrading_version_8.html#declaring_client_module_dependencies)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just making sure it wasn't an accidental commit

@breskeby
Copy link
Contributor Author

just a draft till 8.7 is released

@breskeby breskeby marked this pull request as draft February 29, 2024 16:07
@breskeby breskeby changed the title Update Gradle wrapper to 8.7-rc-1 Update Gradle wrapper to 8.7-rc-2 Mar 1, 2024
@brianseeders brianseeders added :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team and removed needs:triage Requires assignment of a team area label labels Mar 1, 2024
@breskeby breskeby self-assigned this Mar 2, 2024
@breskeby breskeby force-pushed the update-gradle-wrapper-87 branch from 6f9ee56 to fa2f1c4 Compare March 12, 2024 08:48
@breskeby breskeby changed the title Update Gradle wrapper to 8.7-rc-2 Update Gradle wrapper to 8.7-rc-3 Mar 12, 2024
@breskeby breskeby changed the title Update Gradle wrapper to 8.7-rc-3 Update Gradle wrapper to 8.7-rc-4 Mar 22, 2024
@breskeby breskeby force-pushed the update-gradle-wrapper-87 branch from e6b2e73 to d20561e Compare March 24, 2024 19:16
@breskeby breskeby changed the title Update Gradle wrapper to 8.7-rc-4 Update Gradle wrapper to 8.7 Mar 24, 2024
@breskeby
Copy link
Contributor Author

8.7. just got released.

@breskeby breskeby marked this pull request as ready for review March 24, 2024 19:20
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby added >non-issue v8.13.1 v7.17.20 auto-backport Automatically create backport pull requests when merged labels Mar 25, 2024
@breskeby breskeby merged commit c15f727 into elastic:main Mar 25, 2024
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Mar 25, 2024
removed tiny issue on build script that seems like an oversight and doesn't do anything at all
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.13
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 105854

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Mar 25, 2024
removed tiny issue on build script that seems like an oversight and doesn't do anything at all

(cherry picked from commit c15f727)

# Conflicts:
#	x-pack/plugin/ent-search/build.gradle
@breskeby
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
7.17

Questions ?

Please refer to the Backport tool documentation

breskeby added a commit that referenced this pull request Mar 26, 2024
removed tiny issue on build script that seems like an oversight and doesn't do anything at all

(cherry picked from commit c15f727)

# Conflicts:
#	x-pack/plugin/ent-search/build.gradle
breskeby added a commit that referenced this pull request Mar 26, 2024
removed tiny issue on build script that seems like an oversight and doesn't do anything at all
@breskeby breskeby deleted the update-gradle-wrapper-87 branch March 26, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.17.20 v8.13.1 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants