Change reindex.remote.whitelist from string to array in example
#109263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shainaraskas
added
>docs
|
Documentation preview: |
elasticsearchmachine
added
v8.15.0
Team:Distributed (Obsolete)
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
leemthompo
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
LGTM. This Cloud doc uses an array for this value and found some other internal tests that explicitly expect an array here.
shainaraskas
added a commit
to shainaraskas/elasticsearch
that referenced
this pull request
Jun 13, 2024
(cherry picked from commit d12a318)
shainaraskas
added a commit
to shainaraskas/elasticsearch
that referenced
this pull request
Jun 13, 2024
(cherry picked from commit d12a318)
shainaraskas
added a commit
to shainaraskas/elasticsearch
that referenced
this pull request
Jun 13, 2024
(cherry picked from commit d12a318)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
shainaraskas
added a commit
that referenced
this pull request
Jun 13, 2024
shainaraskas
added a commit
that referenced
this pull request
Jun 13, 2024
shainaraskas
added a commit
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @BasileMartin, the shape of the reindex.remote.whitelist is not allowed to be a string, it is only allowed to be a list
fixed example so it's an array
tested as valid in cloud env