Skip to content

Conversation

jonathan-buttner
Copy link
Contributor

This PR updates the rest api spec for the inference APIs to be inline with the changes that are going in here: elastic/elasticsearch-specification#3545

This PR needs to be merged first before the elasticsearch-specification PR can be merged.

The docs might need to be updated in a few places but I'll need to do that directly to 8.x and potential in main separately.

@jonathan-buttner jonathan-buttner added >refactoring :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Mar 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@jonathan-buttner
Copy link
Contributor Author

Docs changes: #124157

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"inference.stream_completion": {
"documentation": {
"url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/post-stream-inference-api.html",
"description": "Perform streaming inference"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Perform streaming inference"
"description": "Perform streaming completion inference"

@jonathan-buttner jonathan-buttner merged commit 3a472eb into elastic:main Mar 6, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 124151

jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request Mar 6, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc
elasticsearchmachine pushed a commit that referenced this pull request Mar 6, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc
@jonathan-buttner
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x
8.18

Questions ?

Please refer to the Backport tool documentation

jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request Mar 6, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc

(cherry picked from commit 3a472eb)

# Conflicts:
#	x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/inference/inference_crud.yml
jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request Mar 6, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc

(cherry picked from commit 3a472eb)

# Conflicts:
#	x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/inference/inference_crud.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 6, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc

(cherry picked from commit 3a472eb)

# Conflicts:
#	x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/inference/inference_crud.yml
elasticsearchmachine pushed a commit that referenced this pull request Mar 6, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc

(cherry picked from commit 3a472eb)

# Conflicts:
#	x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/inference/inference_crud.yml
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc
costin pushed a commit to costin/elasticsearch that referenced this pull request Mar 15, 2025
* Pulling api spec changes

* Fixing test and updating code javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :ml Machine learning >refactoring Team:ML Meta label for the ML team v8.18.0 v8.18.1 v8.19.0 v9.0.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants