Skip to content

[Deprecation] Update URL (#124259) #124269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

[Deprecation] Update URL (#124259) #124269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4b4a9f
[Deprecation] Update URL (#124259)
prwhelan Mar 6, 2025
3249939
Fix checkstyle
prwhelan Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...eprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ private DeprecationIssue oldIndicesCheck(
return new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
"One or more Transforms write to this index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html"
+ "#breaking_90_transform_destination_index",
Strings.format(
"This index was created in version [%s] and requires action before upgrading to 9.0. The following transforms are "
Expand All @@ -119,7 +119,7 @@ private DeprecationIssue oldIndicesCheck(
return new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
"Old index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html",
"This index has version: " + currentCompatibilityVersion.toReleaseVersion(),
false,
Map.of("reindex_required", true)
Expand All @@ -146,7 +146,7 @@ private DeprecationIssue ignoredOldIndicesCheck(
return new DeprecationIssue(
DeprecationIssue.Level.WARNING,
"One or more Transforms write to this old index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html"
+ "#breaking_90_transform_destination_index",
Strings.format(
"This index was created in version [%s] and will be supported as a read-only index in 9.0. The following "
Expand All @@ -162,7 +162,7 @@ private DeprecationIssue ignoredOldIndicesCheck(
return new DeprecationIssue(
DeprecationIssue.Level.WARNING,
"Old index with a compatibility version < 8.0 has been ignored",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking-changes-9.0.html",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html",
"This read-only index has version: "
+ currentCompatibilityVersion.toReleaseVersion()
+ " and will be supported as read-only in 9.0",
Expand Down
24 changes: 10 additions & 14 deletions ...ation/src/test/java/org/elasticsearch/xpack/deprecation/IndexDeprecationCheckerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void testOldIndicesCheck() {
DeprecationIssue expected = new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
"Old index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html",
"This index has version: " + OLD_VERSION.toReleaseVersion(),
false,
singletonMap("reindex_required", true)
Expand All @@ -104,8 +104,7 @@ public void testOldTransformIndicesCheck() {
var expected = new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
"One or more Transforms write to this index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
+ "#breaking_90_transform_destination_index",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
+ "] and requires action before upgrading to 9.0. "
Expand All @@ -131,8 +130,7 @@ public void testOldIndicesCheckWithMultipleTransforms() {
var expected = new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
"One or more Transforms write to this index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
+ "#breaking_90_transform_destination_index",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
+ "] and requires action before upgrading to 9.0. "
Expand Down Expand Up @@ -162,7 +160,7 @@ public void testMultipleOldIndicesCheckWithTransforms() {
new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
"One or more Transforms write to this index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html"
+ "#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
Expand All @@ -178,7 +176,7 @@ public void testMultipleOldIndicesCheckWithTransforms() {
new DeprecationIssue(
DeprecationIssue.Level.CRITICAL,
"One or more Transforms write to this index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html"
+ "#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
Expand Down Expand Up @@ -285,7 +283,7 @@ public void testOldIndicesIgnoredWarningCheck() {
DeprecationIssue expected = new DeprecationIssue(
DeprecationIssue.Level.WARNING,
"Old index with a compatibility version < 8.0 has been ignored",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking-changes-9.0.html",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html",
"This read-only index has version: " + OLD_VERSION.toReleaseVersion() + " and will be supported as read-only in 9.0",
false,
singletonMap("reindex_required", true)
Expand Down Expand Up @@ -336,8 +334,7 @@ public void testOldTransformIndicesIgnoredCheck() {
var expected = new DeprecationIssue(
DeprecationIssue.Level.WARNING,
"One or more Transforms write to this old index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
+ "#breaking_90_transform_destination_index",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
+ "] and will be supported as a read-only index in 9.0. "
Expand All @@ -363,8 +360,7 @@ public void testOldIndicesIgnoredCheckWithMultipleTransforms() {
var expected = new DeprecationIssue(
DeprecationIssue.Level.WARNING,
"One or more Transforms write to this old index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
+ "#breaking_90_transform_destination_index",
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
+ "] and will be supported as a read-only index in 9.0. "
Expand Down Expand Up @@ -394,7 +390,7 @@ public void testMultipleOldIndicesIgnoredCheckWithTransforms() {
new DeprecationIssue(
DeprecationIssue.Level.WARNING,
"One or more Transforms write to this old index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html"
+ "#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
Expand All @@ -410,7 +406,7 @@ public void testMultipleOldIndicesIgnoredCheckWithTransforms() {
new DeprecationIssue(
DeprecationIssue.Level.WARNING,
"One or more Transforms write to this old index with a compatibility version < 8.0",
"https://www.elastic.co/guide/en/elasticsearch/reference/current/migrating-9.0.html"
"https://www.elastic.co/guide/en/elastic-stack/9.0/upgrading-elastic-stack.html"
+ "#breaking_90_transform_destination_index",
"This index was created in version ["
+ OLD_VERSION.toReleaseVersion()
Expand Down