Skip to content

ESQL: supplement docs on LIMIT #125839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

ESQL: supplement docs on LIMIT #125839

merged 3 commits into from
Mar 28, 2025
+36 −2

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Mar 28, 2025

This adds a few extra details around how ESQL processes input docs and how it limits output results.

Closes #125819

@bpintea
Improve docs on LIMIT
986a574 
This adds a few extra details around how ESQL processes input docs and
how it limits output results.
@bpintea bpintea added >docs General docs changes auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.18.1 v8.19.0 v9.0.1 v9.1.0 v8.17.5 labels Mar 28, 2025
@bpintea bpintea requested review from costin and leemthompo March 28, 2025 12:40
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Mar 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

leemthompo
leemthompo reviewed Mar 28, 2025
View reviewed changes
costin
costin approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the quick turnaround.

@bpintea @leemthompo
Update docs/reference/query-languages/esql/limitations.md
6e2821c 
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@bpintea bpintea added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 28, 2025
@elasticsearchmachine elasticsearchmachine merged commit 1bd80d1 into elastic:main Mar 28, 2025
5 of 6 checks passed
@bpintea bpintea deleted the docs/limit_details branch March 28, 2025 19:03
@bpintea bpintea mentioned this pull request Mar 28, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts
✅ 9.0
❌ 8.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 125839

bpintea added a commit to bpintea/elasticsearch that referenced this pull request Mar 28, 2025
@bpintea
ESQL: supplement docs on LIMIT (elastic#125839)
36817a4 
This adds a few extra details around how ESQL processes input docs and
how it limits output results.

Closes elastic#125819
elasticsearchmachine pushed a commit that referenced this pull request Mar 28, 2025
@bpintea
ESQL: supplement docs on LIMIT (#125839) (#125888)
b2a0078 
This adds a few extra details around how ESQL processes input docs and
how it limits output results.

Closes #125819
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
@bpintea @omricohenn
ESQL: supplement docs on LIMIT (elastic#125839)
2c0258b 
This adds a few extra details around how ESQL processes input docs and
how it limits output results.

Closes elastic#125819
@bmorelli25 bmorelli25 mentioned this pull request Mar 28, 2025
Merged
@leemthompo
Copy link
Contributor

leemthompo commented Mar 31, 2025 •
edited
Loading

@bpintea this PR was merged with a broken doc build! It turns out the fragment ID in this URL doesn't exist. So my suggestion was incomplete, needed more than just to swap .html for .md. But in any case we need to make sure CI is green before merging 😄

@bpintea
Copy link
Contributor Author

bpintea commented Mar 31, 2025

this PR was merged with a broken doc build!

Oh, sorry for that!

But in any case we need to make sure CI is green before merging 😄

It seems that the docs-preview / build check did indeed fail. This PR was automerged, not sure why this check is optional before merging.

@leemthompo
Copy link
Contributor

I think it might be because used auto-merge-without-approval label instead of just enabling auto-merge via the GitHub UI

cc @bmorelli25 @Mpdreamz will want to ensure this can't happen again with auto-merges in the ES repo :)

@leemthompo
Copy link
Contributor

I wonder if could get the new docs build connected to HOMER

@bpintea bpintea mentioned this pull request Mar 31, 2025
Merged
bpintea added a commit that referenced this pull request Apr 7, 2025
@bpintea
[8.x] ESQL: supplement docs on LIMIT (#125967)
55df9f2 
Backport of #125839.
bpintea added a commit to bpintea/elasticsearch that referenced this pull request Apr 7, 2025
@bpintea
[8.x] ESQL: supplement docs on LIMIT (elastic#125967)
965b43a 
Backport of elastic#125839.
bpintea added a commit to bpintea/elasticsearch that referenced this pull request Apr 7, 2025
@bpintea
[8.x] ESQL: supplement docs on LIMIT (elastic#125967)
24ee621 
Backport of elastic#125839.
elasticsearchmachine pushed a commit that referenced this pull request Apr 7, 2025
@bpintea
[8.x] ESQL: supplement docs on LIMIT (#125967) (#126395)
cf88b88 
Backport of #125839.
elasticsearchmachine pushed a commit that referenced this pull request Apr 7, 2025
@bpintea
[8.x] ESQL: supplement docs on LIMIT (#125967) (#126396)
d832cb6 
Backport of #125839.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo left review comments

@costin costin costin approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.17.5 v8.18.1 v8.19.0 v9.0.1 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESQL: Improved documentation on ESQL limits
4 participants
@bpintea @elasticsearchmachine @leemthompo @costin