Update InferenceException to retain top-level message #126345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
>non-issue
auto-backport
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
kderusso
approved these changes
Apr 7, 2025
| public RestStatus status() { | ||
| // Override status so that we get the status of the cause while retaining the message of the inference exception when emitting to | ||
| // XContent | ||
| return ExceptionsHelper.status(getCause()); |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Apr 7, 2025
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Apr 7, 2025
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Apr 7, 2025
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
Apr 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
InferenceExceptionto retain the top-level message when converted to XContent. The purpose ofInferenceExceptionis to pass through the status of the cause while retaining the top-level message for better error traceability, which it wasn't doing before.With this change, an
InferenceExceptionemitted to XContent looks like:{ "type": "inference_exception", "reason": "test wrapper", "caused_by": { "type": "status_exception", "reason": "test" } }