Skip to content

Remove reference to dropped EIS API #126422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Remove reference to dropped EIS API #126422

merged 3 commits into from
Apr 9, 2025

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock commented Apr 7, 2025

No description provided.

@JoshMock JoshMock requested a review from pquentin April 7, 2025 16:53
@elasticsearchmachine
Copy link
Collaborator

@JoshMock please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 7, 2025
@JoshMock JoshMock added :ml Machine learning Team:ML Meta label for the ML team labels Apr 7, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Apr 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@pquentin
Copy link
Member

pquentin commented Apr 8, 2025

The API was not actually dropped, but my understanding is that we don't want to advertise it.

@JoshMock JoshMock enabled auto-merge (squash) April 8, 2025 15:46
@JoshMock JoshMock requested a review from a team April 8, 2025 15:46
@JoshMock JoshMock merged commit 5f871c5 into main Apr 9, 2025
18 checks passed
@JoshMock JoshMock deleted the eis-cleanup branch April 9, 2025 08:06
@pquentin pquentin added auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 labels Apr 9, 2025
This was referenced Apr 9, 2025
Merged
Merged
@pquentin
Copy link
Member

pquentin commented Apr 9, 2025

💔 Some backports could not be created

Status Branch Result
✅ 8.x
❌ 9.0 Cherrypick failed because the selected commit (5f871c5) is empty. Did you already backport this commit?
✅ 8.18

Manual backport

To create the backport manually run:

backport --pr 126422

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit to pquentin/elasticsearch that referenced this pull request Apr 9, 2025
@JoshMock @pquentin
Remove reference to dropped EIS API (elastic#126422)
97696b7 
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 5f871c5)
pquentin added a commit that referenced this pull request Apr 9, 2025
@pquentin @JoshMock
Remove reference to dropped EIS API (#126422) (#126512)
a4e9729 
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 5f871c5)

Co-authored-by: Josh Mock <joshua.mock@elastic.co>
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126422

pquentin added a commit that referenced this pull request Apr 10, 2025
@pquentin @JoshMock
Remove reference to dropped EIS API (#126422) (#126513)
04af7c8 
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 5f871c5)

Co-authored-by: Josh Mock <joshua.mock@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pquentin pquentin pquentin approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending external-contributor Pull request authored by a developer outside the Elasticsearch team :ml Machine learning >non-issue Team:ML Meta label for the ML team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoshMock @elasticsearchmachine @pquentin