Skip to content

Conversation

pawankartik-elastic
Copy link
Contributor

@pawankartik-elastic pawankartik-elastic commented Apr 23, 2025

While the assert statements check were checking for values, they were also asserting their order. This fix instead relies on hasItemInArray() like we do in order tests.

Fixes #126893.

@pawankartik-elastic pawankartik-elastic added auto-backport Automatically create backport pull requests when merged Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/CCS v9.0.1 v9.1.0 labels Apr 23, 2025
@pawankartik-elastic pawankartik-elastic changed the title Fix failing test: assert only values and not their specific order Fix CrossClusterEsqlRCS1EnrichUnavailableRemotesIT failing: assert only values and not their specific order Apr 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@pawankartik-elastic pawankartik-elastic merged commit 1891f99 into elastic:main Apr 23, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >non-issue :Search Foundations/CCS Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] CrossClusterEsqlRCS1EnrichUnavailableRemotesIT testEsqlEnrichWithSkipUnavailable failing

3 participants