Skip to content

Conversation

ioanatia
Copy link
Contributor

This fixes an issue in the match_phrase docs, where there's no break and no indentation for the valid values of zero_terms_query option. none and all appear to be options of match_phrase, when they are actually valid values of zero_terms_query.

Screenshot 2025-05-23 at 16 28 19

@ioanatia ioanatia added >docs General docs changes Team:Docs Meta label for docs team labels May 23, 2025
@ioanatia ioanatia requested a review from leemthompo May 23, 2025 16:15
@ioanatia ioanatia marked this pull request as ready for review May 23, 2025 16:15
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo
Copy link
Contributor

Thanks @ioanatia, but looks like there might still be some tweaking to be done on indentation, looking at the URL preview

@leemthompo
Copy link
Contributor

leemthompo commented May 23, 2025

See https://elastic.github.io/docs-builder/syntax/definition-lists/ I know these are finicky indentation-wise

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting that empty line should fix it I think

…-phrase.md

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v9.0.0 labels May 23, 2025
@leemthompo
Copy link
Contributor

leemthompo commented May 23, 2025

Hurray! nothing like some really finicky indentation syntax to finish up the week 😜 😵‍💫

@ioanatia
Copy link
Contributor Author

ioanatia commented May 23, 2025

yay it looks right:

Screenshot 2025-05-23 at 18 43 43

I was beginning to doubt my sanity given that it looked right in 3 editors I tested, but not in the docs preview 😅

@ioanatia ioanatia merged commit 55956d4 into elastic:main May 23, 2025
7 checks passed
@ioanatia ioanatia deleted the match_phrase_query_docs branch May 23, 2025 17:33
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Docs Meta label for docs team v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants