Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS SDK to 1.10.10 #12859

Closed
wants to merge 2 commits into from
Closed

Update AWS SDK to 1.10.10 #12859

wants to merge 2 commits into from

Conversation

Fsero
Copy link

@Fsero Fsero commented Aug 13, 2015

@dadoonet
Copy link
Member

The pom.xml change is missing, right?

@Fsero
Copy link
Author

Fsero commented Aug 13, 2015

is already on 1.10.10 thats because i didnt change it see on https://github.com/elastic/elasticsearch/blob/master/plugins/cloud-aws/pom.xml#L19

@dadoonet
Copy link
Member

It's 1.10.0 right?

@Fsero
Copy link
Author

Fsero commented Aug 13, 2015

Ohh!! totally sorry about that :)

dadoonet
dadoonet reviewed Aug 13, 2015
View reviewed changes
plugins/cloud-aws/src/test/java/org/elasticsearch/cloud/aws/AmazonS3Wrapper.java
* regarding copyright ownership. Author licenses this
* file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the License header as it was?

@dadoonet dadoonet changed the title added test for 1.10.10 aws sdk [cloud-aws] Update AWS SDK to 1.10.10 aws sdk Aug 13, 2015
@dadoonet dadoonet changed the title [cloud-aws] Update AWS SDK to 1.10.10 aws sdk [cloud-aws] Update AWS SDK to 1.10.10 Aug 13, 2015
@dadoonet dadoonet self-assigned this Aug 13, 2015
@Fsero
Copy link
Author

Fsero commented Aug 13, 2015

done.

@dadoonet dadoonet mentioned this pull request Aug 17, 2015
Merged
@lusid lusid mentioned this pull request Aug 18, 2015
Closed
@daviddyball
Copy link

Will this change get back-ported to the 1.4 Docker containers or will it only come to 1.7+ versions of ES? Currently the errors in elastic/elasticsearch-cloud-aws#233 are preventing us from implementing correct backup/restore functionality with an S3 backend and we can't progress until this is fixed.

@FestivalBobcats
Copy link

I'm curious as well how to patch ES 1.4.x - 1.7.0. I've applied the changes here in the 1.4 branch but tests are failing.

@jhansen-tt
Copy link

Please release 1.7.2 ASAP with this fix. This is a major issue.

@dadoonet
Copy link
Member

@jhansen-tt feel Free to test the SNAPSHOT version and report in this PR elastic/elasticsearch-cloud-aws#234 (comment)

@jhansen-tt
Copy link

Is there a SNAPSHOT PPA?

@dadoonet
Copy link
Member

Just follow the instructions in the PR comment.
Thanks!

dadoonet pushed a commit that referenced this pull request Aug 24, 2015
@dadoonet
[cloud-aws] Update AWS SDK to 1.10.10
0c97a86 
Closes #12859.

(cherry picked from commit 3efa641)
dadoonet added a commit that referenced this pull request Aug 24, 2015
@dadoonet
[cloud-aws] Update AWS SDK to 1.10.10
80a9a37 
Update SHA1 files.

Closes #12859.

(cherry picked from commit 528b438)
@dadoonet dadoonet closed this in 3efa641 Aug 24, 2015
dadoonet added a commit that referenced this pull request Aug 24, 2015
@dadoonet
[cloud-aws] Update AWS SDK to 1.10.10
528b438 
Update SHA1 files.

Closes #12859.
@dadoonet dadoonet mentioned this pull request Aug 24, 2015
Merged
@clintongormley clintongormley changed the title [cloud-aws] Update AWS SDK to 1.10.10 Update AWS SDK to 1.10.10 Sep 16, 2015
@clintongormley clintongormley added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Cloud AWS labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dadoonet dadoonet

Labels
blocker :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >upgrade v2.0.0-beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Fsero @dadoonet @daviddyball @FestivalBobcats @jhansen-tt @clintongormley