-
Notifications
You must be signed in to change notification settings - Fork 25.5k
[8.19] Fix FetchSourceContext serialization for mixed-version clusters #129172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.19] Fix FetchSourceContext serialization for mixed-version clusters #129172
Conversation
Ensure the new exclude_vectors parameter is correctly serialized and deserialized when operating in a mixed-version cluster. Given that version 8.19 is not compatible with 9.0, we can assume that all versions on or after 9.1 will support this new parameter.
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
I don't understand how this is broken. @thecoop could you take a look here? |
Using |
I don't understand why this isn't enough. 9.1 should negotiate the appropriate transport version, and 9.1 should know about the patch version. |
Changing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the new exclude_vectors parameter is correctly serialized and deserialized when operating in a mixed-version cluster. Given that version 8.19 is not compatible with 9.0, we can assume that all versions on or after 9.1 will support this new parameter.