Skip to content

[8.17] Fix RestCancellableNodeClientTests.testConcurrentExecuteAndClose() (#129294) #129425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

[8.17] Fix RestCancellableNodeClientTests.testConcurrentExecuteAndClose() (#129294) #129425

merged 1 commit into from
Jun 13, 2025

Conversation

JeremyDahlgren
Copy link
Contributor

Backports the following commits to 8.17:

@JeremyDahlgren
Fix RestCancellableNodeClientTests.testConcurrentExecuteAndClose() (e…
e4c196c 
…lastic#129294)

Fixes a race condition in testConcurrentExecuteAndClose() where
awaitClose() is called before addCloseListener() has been called,
resulting in a situation where closeListener is never completed and
the closeLatch is never pulled.

Closes elastic#129121
@JeremyDahlgren JeremyDahlgren added :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Coordination Meta label for Distributed Coordination team labels Jun 13, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Jun 13, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 8208fcb into elastic:8.17 Jun 13, 2025
16 checks passed
@JeremyDahlgren JeremyDahlgren deleted the backport/8.17/pr-129294 branch June 13, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.17.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeremyDahlgren @elasticsearchmachine