KQL - Prevent boolean operators from being used as literals in tests #134328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures. Fixes elastic#133863, elastic#133871
afoucret
added
>test-failure
elasticsearchmachine
added
needs:risk
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
carlosdelest
approved these changes
Sep 9, 2025
afoucret
added
v9.1.0
v9.1.4
v9.0.7
auto-backport
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 9, 2025
…lastic#134328) * KQL Prevent boolean operators from being used as literals in tests The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures. Fixes elastic#133863, elastic#133871 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Sep 9, 2025
…lastic#134328) * KQL Prevent boolean operators from being used as literals in tests The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures. Fixes elastic#133863, elastic#133871 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Sep 11, 2025
…lastic#134328) * KQL Prevent boolean operators from being used as literals in tests The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures. Fixes elastic#133863, elastic#133871 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit 4ec28fd)
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Sep 11, 2025
…lastic#134328) * KQL Prevent boolean operators from being used as literals in tests The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures. Fixes elastic#133863, elastic#133871 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit 4ec28fd)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 11, 2025
…134328) (#134526) * KQL Prevent boolean operators from being used as literals in tests The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures. Fixes #133863, #133871 * [CI] Auto commit changes from spotless --------- (cherry picked from commit 4ec28fd) Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 11, 2025
…tests (#134328) (#134522) * KQL - Prevent boolean operators from being used as literals in tests (#134328) * KQL Prevent boolean operators from being used as literals in tests The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures. Fixes #133863, #133871 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit 4ec28fd) * Update muted-tests.yml --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KqlParserBooleanQueryTests were failing because the random query generator could pick boolean operators (AND, OR, NOT) as query terms. This would result in queries like "mapped_string":"AND AND NOT", which the parser would interpret as a MatchQueryBuilder instead of the expected BoolQueryBuilder, causing assertion failures.
Fixes #133863
Fixes #133871