Add ability to comment in transport version files #134329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Sep 8, 2025
|
|
||
| public void testComment() { | ||
| byte[] data1 = ("#comment" + System.lineSeparator() + "1000000").getBytes(StandardCharsets.UTF_8); | ||
| TransportVersion test1 = TransportVersion.fromBufferedReader( |
There was a problem hiding this comment.
nit: seems these are all exactly the same test, just with a different comment before the same id. perhaps it could be moved to a helper function that takes the data as a string?
There was a problem hiding this comment.
I'll see if I can make a helper in a separate PR for all the tests that use this byte array.
mark-vieira
reviewed
Sep 8, 2025
| String line; | ||
| do { | ||
| line = bufferedReader.readLine(); | ||
| } while (line.replaceAll("\\s+", "").startsWith("#")); |
There was a problem hiding this comment.
I guess this means we don't support comments anywhere in the file, only in the beginning?
There was a problem hiding this comment.
Correct. Since this is our internal format, I didn't think it was worth additional parsing complexity to make it work anywhere.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 8, 2025
Comments may be added to the beginning of transport version files by starting each comment line with the hash # character.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 8, 2025
Comments may be added to the beginning of transport version files by starting each comment line with the hash # character.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 8, 2025
Comments may be added to the beginning of transport version files by starting each comment line with the hash # character.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 8, 2025
Comments may be added to the beginning of transport version files by starting each comment line with the hash # character.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2025
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 9, 2025
Comments may be added to the beginning of transport version files by starting each comment line with the hash # character.
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Sep 10, 2025
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Sep 10, 2025
BASE=cf671ff721da8a26d4d3e30346b6bb639968f268 HEAD=8021513035fb4cd706874e9b3301dc43fdef0845 Branch=main
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…lastic#134339) Comments may be added to the beginning of transport version files by starting each comment line with the hash # character.
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Sep 16, 2025
BASE=cf671ff721da8a26d4d3e30346b6bb639968f268 HEAD=8021513035fb4cd706874e9b3301dc43fdef0845 Branch=main
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…lastic#134339) Comments may be added to the beginning of transport version files by starting each comment line with the hash # character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments may be added to the beginning of transport version
files by starting each comment line with the hash
#character.