-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Run transport version validation tasks on precommit #134482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mark-vieira
merged 1 commit into
elastic:main
from
mark-vieira:validate-transport-versions-on-precommit
Sep 10, 2025
Merged
Run transport version validation tasks on precommit #134482
mark-vieira
merged 1 commit into
elastic:main
from
mark-vieira:validate-transport-versions-on-precommit
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
Sep 10, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 10, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 10, 2025
(cherry picked from commit 36181aa) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/TransportVersionResourcesPlugin.java
This was referenced Sep 10, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 10, 2025
(cherry picked from commit 36181aa) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/TransportVersionResourcesPlugin.java
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 10, 2025
(cherry picked from commit 36181aa) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/TransportVersionResourcesPlugin.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 10, 2025
…134490) * Run transport version validation tasks on precommit (#134482) (cherry picked from commit 36181aa) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/TransportVersionResourcesPlugin.java * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Core/Infra/Core
Core issues without another label
>refactoring
Team:Core/Infra
Meta label for core/infra team
v8.18.8
v8.19.5
v9.0.8
v9.1.5
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire the transport version validation tasks to
precommit
rather thancheck
. This ensures they run earlier, and doesn't require devs to run tests to ensure transport versions are valid.