Skip to content

Improvements for inference ModelStatsTest #134707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Improvements for inference ModelStatsTest #134707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions ...ugin/core/src/test/java/org/elasticsearch/xpack/core/inference/usage/ModelStatsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,12 @@
import org.elasticsearch.common.io.stream.Writeable;
import org.elasticsearch.inference.TaskType;
import org.elasticsearch.test.AbstractWireSerializingTestCase;
import org.elasticsearch.test.ESTestCase;

import java.io.IOException;

import static org.hamcrest.Matchers.equalTo;

public class ModelStatsTests extends AbstractWireSerializingTestCase<ModelStats> {

@Override
Expand All @@ -27,12 +30,32 @@ protected ModelStats createTestInstance() {

@Override
protected ModelStats mutateInstance(ModelStats modelStats) throws IOException {
ModelStats newModelStats = new ModelStats(modelStats);
newModelStats.add();
return newModelStats;
String service = modelStats.service();
TaskType taskType = modelStats.taskType();
long count = modelStats.count();
return switch (randomInt(2)) {
case 0 -> new ModelStats(randomValueOtherThan(service, ESTestCase::randomIdentifier), taskType, count);
case 1 -> new ModelStats(service, randomValueOtherThan(taskType, () -> randomFrom(TaskType.values())), count);
case 2 -> new ModelStats(service, taskType, randomValueOtherThan(count, ESTestCase::randomLong));
default -> throw new IllegalArgumentException();
};
}

public void testAdd() {
ModelStats stats = new ModelStats("test_service", randomFrom(TaskType.values()));
assertThat(stats.count(), equalTo(0L));

stats.add();
assertThat(stats.count(), equalTo(1L));

int iterations = randomIntBetween(1, 10);
for (int i = 0; i < iterations; i++) {
stats.add();
}
assertThat(stats.count(), equalTo(1L + iterations));
}

public static ModelStats createRandomInstance() {
return new ModelStats(randomIdentifier(), TaskType.values()[randomInt(TaskType.values().length - 1)], randomInt(10));
return new ModelStats(randomIdentifier(), randomFrom(TaskType.values()), randomLong());
}
}