Make transport version comments parsable #134733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Sep 15, 2025
| } | ||
| } | ||
| } | ||
| if (idsLine != null) { |
There was a problem hiding this comment.
if idsLine is null doesn't that mean we have an empty file (which should be an error)?
There was a problem hiding this comment.
I was preserving how this already was, but happy to change it. WDYT?
There was a problem hiding this comment.
Yeah I think it should be an error. Having an empty file isn't ever valid.
There was a problem hiding this comment.
I want comments available, so I will follow up and add better error coverage to both these methods in a follow up. There's a few more things to look for in the parsing that we do in ES, but not gradle still.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 16, 2025
This adds the ability to filter comments from transport version internal state files during parsing in gradle tasks.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 16, 2025
This adds the ability to filter comments from transport version internal state files during parsing in gradle tasks.
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 16, 2025
This adds the ability to filter comments from transport version internal state files during parsing in gradle tasks.
This was referenced Sep 16, 2025
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 16, 2025
This adds the ability to filter comments from transport version internal state files during parsing in gradle tasks.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 16, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
This adds the ability to filter comments from transport version internal state files during parsing in gradle tasks.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
This adds the ability to filter comments from transport version internal state files during parsing in gradle tasks.
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Sep 23, 2025
BASE=d662314b371d340e211d70e3b61cbe8b0bd42330 HEAD=21d04e11bb80b116384ce2bbf4943d1bed47ccc5 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 2, 2025
BASE=d662314b371d340e211d70e3b61cbe8b0bd42330 HEAD=21d04e11bb80b116384ce2bbf4943d1bed47ccc5 Branch=main
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 6, 2025
BASE=d662314b371d340e211d70e3b61cbe8b0bd42330 HEAD=21d04e11bb80b116384ce2bbf4943d1bed47ccc5 Branch=main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to filter comments from transport version internal state files during parsing in gradle tasks.