ESQL: Standardize block args #135160
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.compute.ann; | ||
|
|
||
| import java.lang.annotation.ElementType; | ||
| import java.lang.annotation.Retention; | ||
| import java.lang.annotation.RetentionPolicy; | ||
| import java.lang.annotation.Target; | ||
|
|
||
| /** | ||
| * Used on parameters on methods annotated with {@link Evaluator} or in | ||
| * {@link Aggregator} or {@link GroupingAggregator} to indicate an argument | ||
| * that is the position in a block. | ||
| */ | ||
| @Target(ElementType.PARAMETER) | ||
| @Retention(RetentionPolicy.SOURCE) | ||
| public @interface Position { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.compute.gen.argument; | ||
|
|
||
| import com.squareup.javapoet.MethodSpec; | ||
| import com.squareup.javapoet.TypeName; | ||
| import com.squareup.javapoet.TypeSpec; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** | ||
| * The position in a block. | ||
| */ | ||
| public record PositionArgument() implements Argument { | ||
| @Override | ||
| public TypeName dataType(boolean blockStyle) { | ||
| return TypeName.INT; | ||
| } | ||
|
|
||
| @Override | ||
| public String paramName(boolean blockStyle) { | ||
| // No need to pass it | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public void declareField(TypeSpec.Builder builder) { | ||
| // Nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void declareFactoryField(TypeSpec.Builder builder) { | ||
| // Nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void implementCtor(MethodSpec.Builder builder) { | ||
| // Nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void implementFactoryCtor(MethodSpec.Builder builder) { | ||
| // Nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public String factoryInvocation(MethodSpec.Builder factoryMethodBuilder) { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public void evalToBlock(MethodSpec.Builder builder) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void closeEvalToBlock(MethodSpec.Builder builder) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void resolveVectors(MethodSpec.Builder builder, String invokeBlockEval) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void createScratch(MethodSpec.Builder builder) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void skipNull(MethodSpec.Builder builder) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void allBlocksAreNull(MethodSpec.Builder builder) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void read(MethodSpec.Builder builder, boolean blockStyle) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public void buildInvocation(StringBuilder pattern, List<Object> args, boolean blockStyle) { | ||
| pattern.append("p"); | ||
| } | ||
|
|
||
| @Override | ||
| public void buildToStringInvocation(StringBuilder pattern, List<Object> args, String prefix) { | ||
| // nothing to do | ||
| } | ||
|
|
||
| @Override | ||
| public String closeInvocation() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public void sumBaseRamBytesUsed(MethodSpec.Builder builder) {} | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the next PR I should be ale to remove this
instanceofand just us theArgumentdirectly. It'll need a few more methods, but should be fine.