Fix expiration time in ES|QL async #135209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
fix-async-expiration
branch
from
5be018a to
02e4013
Compare
|
Hi @dnhatn, I've created a changelog YAML for you. |
dnhatn
commented
Sep 22, 2025
| storeResults( | ||
| searchTask, | ||
| new StoredAsyncResponse<>(response, threadPool.absoluteTimeInMillis() + keepAlive.getMillis()), | ||
| new StoredAsyncResponse<>(response, searchTask.getExpirationTimeMillis()), |
There was a problem hiding this comment.
These lines are the main fix.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Sep 22, 2025
dnhatn
added
the
auto-backport
|
Thanks Nik! |
This was referenced Sep 22, 2025
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 22, 2025
Currently, we incorrectly use the initial keep-alive value when creating the document for the async response. Instead, we should use the latest expiration from the search task, which is updated by get requests. Closes elastic#135169
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 22, 2025
Currently, we incorrectly use the initial keep-alive value when creating the document for the async response. Instead, we should use the latest expiration from the search task, which is updated by get requests. Closes elastic#135169
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we incorrectly use the initial keep-alive value when creating the document for the async response. Instead, we should use the latest expiration from the search task, which is updated by get requests.
Closes #135169