Cleanup of IndexSettingProvider #135251
Merged
Cleanup of IndexSettingProvider #135251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#133232, we've added the ability to provide index metadata with an IndexSettingProvider. It turned out that we don't need that functionality as we ended up using a private index setting in elastic#132566. This also adds the `IndexVersion` as another parameter. This is in preparation for [this](elastic#132566 (comment)) suggestion to conditionally set one or another setting, depending on the index version.
felixbarny
added
:Data Management/Indices APIs
elasticsearchmachine
added
v9.2.0
external-contributor
|
Pinging @elastic/es-data-management (Team:Data Management) |
3 tasks
elasticsearchmachine
added
the
serverless-linked
dakrone
approved these changes
Sep 23, 2025
...treams/src/main/java/org/elasticsearch/datastreams/action/TransportGetDataStreamsAction.java
Outdated
Show resolved
Hide resolved
…x-version' into index-settings-provider-index-version
It can't provide custom metadata anymore
Otherwise, they can't rely on the provided version to be the one that will be actually used for the created index.
|
Pointing out a change for how the The final index version is now determined before calling any To resolve the index version, I'm now considering both the request settings and the template settings and I'm filtering out user-provided settings for failure indices (such as the index version) as it's done later in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #133232, we've added the ability to provide index metadata with an IndexSettingProvider. It turned out that we don't need that functionality as we ended up using a private index setting in #132566.
This also adds the
IndexVersionas another parameter. This is in preparation for this suggestion to conditionally set one or another setting, depending on the index version.