-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Add origin to client in SLM task #135484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origin to client in SLM task #135484
Conversation
The previous tests did not catch this because |
Hi @samxbr, I've created a changelog YAML for you. |
Pinging @elastic/es-data-management (Team:Data Management) |
final SnapshotHistoryStore historyStore | ||
) { | ||
this.projectId = projectId; | ||
this.client = client; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just wrap the client here, so that it does not need to be wrapped in any other place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering that too, and alternatively I was also thinking about adding it here, but didn't do it because maybe we will want to use a different origin on other place in this class?
But on second thought now, we could always wrap again if we need to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should this be backported also? (I can't remember if we need it elsewhere)
Double checked, the related SLM change was on 9.2 |
This change grants the
client
privilege to call the get snapshot API.