Skip to content

Conversation

samxbr
Copy link
Contributor

@samxbr samxbr commented Sep 25, 2025

This change grants the client privilege to call the get snapshot API.

@samxbr samxbr added the >bug label Sep 25, 2025
@samxbr samxbr changed the title Use INDEX_LIFECYCLE_ORIGIN in SLM task Add origin to client in SLM task Sep 25, 2025
@samxbr samxbr requested a review from dakrone September 25, 2025 21:53
@samxbr
Copy link
Contributor Author

samxbr commented Sep 25, 2025

The previous tests did not catch this because security is not enabled by default. I want to get the change up first, will also look into testing with security.

@samxbr samxbr marked this pull request as ready for review September 25, 2025 22:06
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Sep 25, 2025
@samxbr samxbr added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Sep 25, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Sep 25, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @samxbr, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 25, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

final SnapshotHistoryStore historyStore
) {
this.projectId = projectId;
this.client = client;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just wrap the client here, so that it does not need to be wrapped in any other place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering that too, and alternatively I was also thinking about adding it here, but didn't do it because maybe we will want to use a different origin on other place in this class?

But on second thought now, we could always wrap again if we need to.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should this be backported also? (I can't remember if we need it elsewhere)

@samxbr
Copy link
Contributor Author

samxbr commented Sep 26, 2025

LGTM, should this be backported also? (I can't remember if we need it elsewhere)

Double checked, the related SLM change was on 9.2

@samxbr samxbr merged commit de92d49 into elastic:main Sep 26, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants