Only disable unlicensed pattern_text templating when mapper is used #135561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>non-issue
Team:StorageEngine
:StorageEngine/Mapping
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
reviewed
Sep 29, 2025
| for (CompressedXContent mappingSource : combinedTemplateMappings) { | ||
| var ref = mappingSource.compressedReference(); | ||
| if (maybeUsesPatternText == false) { | ||
| maybeUsesPatternText = mappingSource.string().contains(PatternTextFieldType.CONTENT_TYPE); |
There was a problem hiding this comment.
I think that just checking whether mapping contains pattern_text string can also give false positives. For example if field name is named pattern_text. We would need to search for "type":"pattern_text", but we would need to be lenient with whitespaces.
Maybe instead we should MappingVisitor here after line 268. Then we already parsed the mapping as a map. Then checking for type key with pattern_text value is less error prone.
parkertimmins
approved these changes
Sep 29, 2025
jordan-powers
deleted the
disable-unlicensed-pattern-text-only-when-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always set the
index.mapping.pattern_text.disable_templatingsetting for every standard-mode index.This is a bit excessive, so this PR updates the logic to only include the setting if pattern_text field mappers are in use.
Instantiating a whole mapper service just to check for the existence of a PatternedTextMapper would be fairly expensive. So instead this patch simply checks the mapping source for the string "pattern_text". While there may be some false positives, the only overhead of a false positive is that a single index setting is set and then ignored.
This is an alternate approach to #135553