Skip to content

Fix RestoreInProgressAllocationDeciderTests #135593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Fix RestoreInProgressAllocationDeciderTests #135593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96ee518
Fix RestoreInProgressAllocationDeciderTests
nicktindall Sep 29, 2025
04855b8
Merge remote-tracking branch 'origin/main' into fix_RestoreInProgress…
nicktindall Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,9 +579,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.single_node.EsqlSpecIT
method: test {csv-spec:spatial_shapes.ConvertCartesianShapeFromStringParseError}
issue: https://github.com/elastic/elasticsearch/issues/135455
- class: org.elasticsearch.cluster.routing.allocation.decider.RestoreInProgressAllocationDeciderTests
method: testCanAllocatePrimaryExistingInRestoreInProgress
issue: https://github.com/elastic/elasticsearch/issues/135566
- class: org.elasticsearch.xpack.esql.inference.textembedding.TextEmbeddingOperatorTests
method: testSimpleCircuitBreaking
issue: https://github.com/elastic/elasticsearch/issues/135569
Expand Down
2 changes: 1 addition & 1 deletion ...ticsearch/cluster/routing/allocation/decider/RestoreInProgressAllocationDeciderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public void testCanAllocatePrimaryExistingInRestoreInProgress() {
UnassignedInfo.Reason reason;
if (randomBoolean()) {
failureCount = randomBoolean() ? 0 : 1;
reason = UnassignedInfo.Reason.ALLOCATION_FAILED;
reason = failureCount > 0 ? UnassignedInfo.Reason.ALLOCATION_FAILED : UnassignedInfo.Reason.NEW_INDEX_RESTORED;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stole the reason from the value that appears in RestoreSnapshotIT#testExplainUnassigableDuringRestore, though I don't think the reason features anywhere in the decider logic so we could probably randomise it?

} else {
failureCount = 0;
reason = currentInfo.reason();
Expand Down