Migrate transport versions 8841_040 through 8841_034 #135654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Sep 29, 2025
| public class SamlInitiateSingleSignOnRequestTests extends ESTestCase { | ||
|
|
||
| private static final TransportVersion IDP_CUSTOM_SAML_ATTRIBUTES = TransportVersion.fromName("idp_custom_saml_attributes"); | ||
| private static final TransportVersion IDP_CUSTOM_SAML_ATTRIBUTES_PATCH = TransportVersion.fromName("idp_custom_saml_attributes") |
There was a problem hiding this comment.
nit: you can use the constant above instead of doing fromName again?
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 30, 2025
Note: this has a small fix for ignoring asm labels when looking for the string constants for transport version names. ES-12334
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 30, 2025
Note: this has a small fix for ignoring asm labels when looking for the string constants for transport version names. ES-12334
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this has a small fix for ignoring asm labels when looking for the string constants for transport version names.
ES-12334