[Build] Restructure ironbank docker image build #135668
Merged
+141
−291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove the shared dockerfile template in favor of a explicit ironbank image, similar to default and wolfi images. We also remove a test `test310IronBankImageHasNoAdditionalLabels` which basically just tested proper distinction in our shared dockerfile which is now not required anymore. This test started failing as redhat started to add org.opencontainers.image.revision tag
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 30, 2025
We remove the shared dockerfile template in favor of a explicit ironbank image, similar to default and wolfi images. We also remove a test `test310IronBankImageHasNoAdditionalLabels` which basically just tested proper distinction in our shared dockerfile which is now not required anymore. This test started failing as redhat started to add org.opencontainers.image.revision tag
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 30, 2025
We remove the shared dockerfile template in favor of a explicit ironbank image, similar to default and wolfi images. We also remove a test `test310IronBankImageHasNoAdditionalLabels` which basically just tested proper distinction in our shared dockerfile which is now not required anymore. This test started failing as redhat started to add org.opencontainers.image.revision tag
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Oct 8, 2025
This is related to elastic#135668
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Oct 8, 2025
This is related to elastic#135668 (cherry picked from commit 5977588)
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Oct 8, 2025
breskeby
added a commit
that referenced
this pull request
Oct 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the shared dockerfile template in favor of a explicit ironbank image,
similar to default and wolfi images.
We also remove a test
test310IronBankImageHasNoAdditionalLabelswhich basically just tested properdistinction in our shared dockerfile which is now not required anymore.
This test started failing as redhat started to add org.opencontainers.image.revision tag