Skip to content

Fix testStopQueryInlineStats - allow wider range of values #135812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
+6 −8
Merged

Fix testStopQueryInlineStats - allow wider range of values #135812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,9 +510,6 @@ tests:
- class: org.elasticsearch.repositories.blobstore.testkit.analyze.MinioRepositoryAnalysisRestIT
method: testRepositoryAnalysis
issue: https://github.com/elastic/elasticsearch/issues/134853
- class: org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT
method: testStopQueryInlinestats
issue: https://github.com/elastic/elasticsearch/issues/134854
- class: org.elasticsearch.xpack.esql.action.CrossClusterCancellationIT
method: testCancelSkipUnavailable
issue: https://github.com/elastic/elasticsearch/issues/134865
Expand All @@ -528,9 +525,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {csv-spec:stats.CountDistinctWithConditions}
issue: https://github.com/elastic/elasticsearch/issues/134993
- class: org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT
method: testStopQueryInlineStats
issue: https://github.com/elastic/elasticsearch/issues/135032
- class: org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT
method: test {csv-spec:fork.ForkBeforeStatsWithWhere}
issue: https://github.com/elastic/elasticsearch/issues/135041
Expand Down
8 changes: 6 additions & 2 deletions ...nalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterAsyncQueryStopIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,13 @@ public void testStopQueryInlineStats() throws Exception {
assertThat(asyncResponse.columns().size(), equalTo(2));
AtomicInteger i = new AtomicInteger(0);
asyncResponse.values().forEachRemaining(row -> {
// We will have all rows here but total will be null since we stopped the inline stats before it could complete
assertThat(row.next(), equalTo(null));
var v = row.next();
// The sum could be null, if the stats did not manage to compute anything before being stopped
// Or it could be 45L if it managed to add 0-9
if (v != null) {
assertThat((long) v, equalTo(45L));
}
v = row.next();
if (v != null) {
assertThat((long) v, lessThanOrEqualTo(10L));
}
Expand Down