Skip to content

[8.19] Fix getBytesRef in ConstantBytesRefVector (#136445) #136455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
+17 −4
Merged

[8.19] Fix getBytesRef in ConstantBytesRefVector (#136445) #136455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...compute/src/main/generated-src/org/elasticsearch/compute/data/ConstantBytesRefVector.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions ...plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/X-ConstantVector.java.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,15 @@ $endif$

@Override
$if(BytesRef)$
public BytesRef getBytesRef(int position, BytesRef ignore) {
public BytesRef getBytesRef(int position, BytesRef scratch) {
scratch.bytes = value.bytes;
scratch.offset = value.offset;
scratch.length = value.length;
return scratch;
$else$
public $type$ get$Type$(int position) {
$endif$
return value;
$endif$
}

@Override
Expand Down
6 changes: 6 additions & 0 deletions x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/data/BasicBlockTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,12 @@ public void testConstantBytesRefBlock() {
assertEmptyLookup(blockFactory, block);
assertInsertNulls(block);
releaseAndAssertBreaker(block);
// modify the offset
var v0 = block.getBytesRef(randomInt(positionCount), new BytesRef());
var v1 = block.getBytesRef(randomInt(positionCount), new BytesRef());
v1.length = 0;
var v2 = block.getBytesRef(randomInt(positionCount), new BytesRef());
assertThat(v2, equalTo(v0));
}
}

Expand Down