Several GeoPoint Cleanups #14021
Merged
Several GeoPoint Cleanups #14021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries that can include scripts make now use of the mock script engine
Move ShardPercolateService creation into IndexShard
…n parameter Before the refactoring we didn't check any invalid settings for strategy and relation in the GeoShapeQueryBuilder. However, using SpatialStrategy.TERM and ShapeRelation.INTERSECTS together is invalid and we tried to protect against that in the validate() method. This PR moves these checks to setter for strategy and relation and adds tests for the new behaviour. Relates to elastic#10217
There is no need to have term vectors service on the shard level where it's created for every shard. This commit moves it to a higher level which makes shard creation slightly simpler and reduces the number of long living objects.
…_level Move ShardTermVectorService to be on indices level as TermVectorService
TermsLookupQueryBuilder was left around only for bw comp reasons, but TermsQueryBuilder is its replacement. We can remove it now that it is clear query refactoring goes in master (3.0).
… none existing index. Closes elastic#13570
…p_query_builder Java api: remove TermsLookupQueryBuilder
Update put-mapping.asciidoc
"now" is not affected by "time_zone" in range queries
fix typo "Seting" to "Setting"
…ions These classes are really duplicates and are just here for historical reasons. We don't need these anymore since the same classes exist in lucene today. This also removes the guice injection for DeletionPolicy and make them shard private.
Remove ES internal deletion policies in favour of Lucenes implementations
Today we use reflection where it's not needed anymore since java8 can pass ctors around. This commit replaces runtime checks with compile time checks which is always preferrable.
currently ByteSizeValue.parse("1GB") is not equal to ByteSizeValue.parse("1024MB")
Closes elastic#13784
This commit adds explicit ids for managing ElasticsearchException serialization. By adding explicit ids and unit tests for them, the ids are less brittle and breakage can be more clearly detected.
Instead just log the same thing we print to the startup console for that case (magic logic), it sucks to do this, but guice exceptions are too much. All other non-guice exceptions will still be fully logged. Closes elastic#13782
…from_es_exception Remove reflection hacks from ElasticsearchException
We previously removed the ability to specify metadata fields inside documents in elastic#11074, but the backcompat left leniency that allowed this to still occur. This change locks down parsing so any metadata field found while parsing a document results in an exception. This only affects 2.0+ indexes; backcompat is maintained. closes elastic#13740
When running in GCE platform, an instance has access to: http://metadata.google.internal/computeMetadata/v1/instance/network-interfaces/0/ip Which gives back the private IP address, for example `10.240.0.2`. http://metadata.google.internal/computeMetadata/v1/instance/network-interfaces/0/externalIp Gives back the public Ip address, for example `130.211.108.21`. As we have for `ec2`, we can support new network host settings: * `_gce:privateIp:X_`: The private IP address of the machine for a given network interface. * `_gce:hostname_`: The hostname of the machine. * `_gce_`: Same as `_gce:privateIp:0_` (recommended). Closes elastic#13605. Closes elastic#13590. BTW resolveIfPossible now throws IOException so code is also updated for ec2 discovery and some basic tests have been added.
Missing spec for [detect_noop](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-update.html?q=update%20a#_literal_detect_noop_literal) parameter.
Mappings: Enforce metadata fields are not passed in documents
Currently it's not possible to specify a timeout for nodes operations (such as node info, node stats, cluster stats and hot threads) via REST-based APIs.
This commit removes and now forbids all uses of com.google.common.net.InetAddresses across the codebase. This is one of the few remaining steps in the eventual removal of Guava as a dependency. Relates elastic#13224
Remove and forbid use of com.google.common.net.InetAddresses
Long running TransportNodesAction requests can retain old cluster states in memory for much longer than needed. This can cause nodes with frequent cluster state updates and long running requests to run out of memory.
This commit removes and now forbids all uses of com.google.common.collect.EvictingQueue across the codebase. This is one of the few remaining steps in the eventual removal of Guava as a dependency. Relates elastic#13224
Remove and forbid use of com.google.common.collect.EvictingQueue
Follow up azure and aws splits, we need to be consistent and rename `cloud-gce` to `discovery-gce`.
Related to elastic#13815
Don't pull translog from shadow engine
When shard becomes active again, immediately increase its indexing buffer instead of waiting for up to 30 seconds while indexing with a tiny (500 KB) indexing buffer.
If the plugin manager cannot successfully install a plugin, ensure that every directory is cleaned up again. This includes plugins/foo config/foo bin/foo Closes elastic#12749
…stem Two test methods didnt have the required check for permissions, so they were not skipped under windows, leading to CI failures.
GeoPoint now has native support in StreamOutput/StreamInput impementing Writable is not necessary. This also adds tests for XContentBuilder rendering GeoPoint
| default: | ||
| throw new IOException("Can't read unknown type [" + type + "]"); | ||
| } | ||
| } | ||
|
|
||
| public GeoPoint readGeoPoint() throws IOException { |
There was a problem hiding this comment.
can you add minimal javadocs like for writeGeoPoint?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR includes #13632 as well as several tests and cleanups related to it.