Change the field mapping index time boost into a query time boost. #16900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
:Search Foundations/Mapping
|
Originated from #12394 (comment) |
| @@ -186,6 +186,7 @@ private static void reverseOrder(ParseContext.InternalParseContext context) { | |||
| } | |||
| } | |||
|
|
|||
| // TODO Should we remove this feature ? It seems that it's not tested nor used. | |||
There was a problem hiding this comment.
+1 it looks like there are some remainders of the boost field mapper that we removed a while ago (eg. there is also ParseContext.docBoost).
|
I think the doc changes might break some links (@clintongormley should be able to confirm) but otherwise it looks good to me. Thanks! |
|
@jpountz I've removed the docBoost from the context and added an entry in the redirects.asciidoc. |
|
This looks great! |
Index time boost will still be applied for indices created before 5.0.0.
jimczi
added a commit
that referenced
this pull request
Mar 4, 2016
Change the field mapping index time boost into a query time boost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index time boost will still be applied for indices created before 5.0.0.