Skip to content

Group client projects under :client #19032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2016
Merged

Group client projects under :client #19032

merged 1 commit into from
Jun 22, 2016

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jun 22, 2016 

:client ---------> :client:low-level
:client-sniffer -> :client:sniffer
:client-test ----> :client:test

This lines the client up with how we do things like modules and plugins.

@nik9000 nik9000 added :Delivery/Build Build or test infrastructure :Core/Infra/REST API REST infrastructure and utilities v5.0.0-alpha5 labels Jun 22, 2016
@nik9000
Copy link
Member Author

nik9000 commented Jun 22, 2016

I think it might also be nice to move the package the files are in to line up with their projects but I'd prefer to wait on that because it'll create a noisy diff.

@nik9000
Copy link
Member Author

nik9000 commented Jun 22, 2016

@javanna and @rjernst what do you think?

@rjernst
Copy link
Member

rjernst commented Jun 22, 2016

I think I would call low-level instead rest? I believe @s1monw has plans to move the transport client into :client:transport

rjernst
rjernst reviewed Jun 22, 2016
View reviewed changes
settings.gradle Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this client-test still here, in addition to client:test?

@rjernst
Copy link
Member

rjernst commented Jun 22, 2016

LGTM, a couple small suggestions.

@nik9000
Copy link
Member Author

nik9000 commented Jun 22, 2016

I think I would call low-level instead rest

I'm fine with that. It is the "low-level" REST client but we can rename it later if we want.

@nik9000
Group client projects under :client
0bf447c 
:client ---------> :client:rest
:client-sniffer -> :client:sniffer
:client-test ----> :client:test

This lines the client up with how we do things like modules and
plugins.
@nik9000 nik9000 merged commit 0bf447c into elastic:master Jun 22, 2016
@nik9000
Copy link
Member Author

nik9000 commented Jun 22, 2016

Thanks for reviewing @rjernst !

@javanna javanna mentioned this pull request Jul 1, 2016
Merged
@clintongormley clintongormley added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch and removed :Core/Infra/REST API REST infrastructure and utilities labels Jul 13, 2016
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v5.0.0-alpha4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nik9000 @rjernst @clintongormley @mark-vieira