Add quiet option to disable console logging #20422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
review
:Delivery/Packaging
| args); | ||
| } | ||
|
|
||
| public void testThatParsingQuietOPtionWorks() throws Exception { |
|
Thank you @tlrx, it looks great. I left some nits but LGTM. Feel free to merge at your discretion. |
tlrx
force-pushed
the
disable-console-logging-in-systemd
branch
from
23b900e
to
488b654
Compare
This commit adds a -q/--quiet option to Elasticsearch so that it does not log anything in the console and closes stdout & stderr streams. This is useful for SystemD to avoid duplicate logs in both journalctl and /var/log/elasticsearch/elasticsearch.log while still allows the JVM to print error messages in stdout/stderr if needed. closes elastic#17220
tlrx
force-pushed
the
disable-console-logging-in-systemd
branch
from
488b654
to
6090c51
Compare
|
@jasontedor Thanks! |
tlrx
added a commit
that referenced
this pull request
Sep 13, 2016
This commit adds a -q/--quiet option to Elasticsearch so that it does not log anything in the console and closes stdout & stderr streams. This is useful for SystemD to avoid duplicate logs in both journalctl and /var/log/elasticsearch/elasticsearch.log while still allows the JVM to print error messages in stdout/stderr if needed. closes #17220 (cherry picked from commit 6090c51)
tlrx
added a commit
that referenced
this pull request
Sep 13, 2016
This commit adds a -q/--quiet option to Elasticsearch so that it does not log anything in the console and closes stdout & stderr streams. This is useful for SystemD to avoid duplicate logs in both journalctl and /var/log/elasticsearch/elasticsearch.log while still allows the JVM to print error messages in stdout/stderr if needed. closes #17220 (cherry picked from commit 6090c51)
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 21, 2016
Since with j`ava-1.8.0-openjdk-1.8.0.111-1.b15.el7_2.x86_64`, the OpenJDK packaged for CentOS and OEL override the default value (`false`) for the JVM option `AssumeMP` and force it to `true` (see [this patch](https://git.centos.org/blob/rpms!!java-1.8.0-openjdk.git/ab03fcc7a277355a837dd4c8500f8f90201ea353/SOURCES!always_assumemp.patch)) Because it is forced to true by default for these packages, the following warning message is printed to the standard output when the Vagrant box has only 1 CPU: > OpenJDK 64-Bit Server VM warning: If the number of processors is expected to increase from one, then you should configure the number of parallel GC threads appropriately using -XX:ParallelGCThreads=N This message will then fail the test introduced in elastic#20422 where we check if no entries have been added to the journal after the service has been started. This commit restore the default value for the `AssumeMP` option for CentOS and OracleServer.
tlrx
added a commit
that referenced
this pull request
Oct 24, 2016
Since with j`ava-1.8.0-openjdk-1.8.0.111-1.b15.el7_2.x86_64`, the OpenJDK packaged for CentOS and OEL override the default value (`false`) for the JVM option `AssumeMP` and force it to `true` (see [this patch](https://git.centos.org/blob/rpms!!java-1.8.0-openjdk.git/ab03fcc7a277355a837dd4c8500f8f90201ea353/SOURCES!always_assumemp.patch)) Because it is forced to true by default for these packages, the following warning message is printed to the standard output when the Vagrant box has only 1 CPU: > OpenJDK 64-Bit Server VM warning: If the number of processors is expected to increase from one, then you should configure the number of parallel GC threads appropriately using -XX:ParallelGCThreads=N This message will then fail the test introduced in #20422 where we check if no entries have been added to the journal after the service has been started. This commit restore the default value for the `AssumeMP` option for CentOS and OracleServer.
tlrx
added a commit
that referenced
this pull request
Oct 24, 2016
Since with j`ava-1.8.0-openjdk-1.8.0.111-1.b15.el7_2.x86_64`, the OpenJDK packaged for CentOS and OEL override the default value (`false`) for the JVM option `AssumeMP` and force it to `true` (see [this patch](https://git.centos.org/blob/rpms!!java-1.8.0-openjdk.git/ab03fcc7a277355a837dd4c8500f8f90201ea353/SOURCES!always_assumemp.patch)) Because it is forced to true by default for these packages, the following warning message is printed to the standard output when the Vagrant box has only 1 CPU: > OpenJDK 64-Bit Server VM warning: If the number of processors is expected to increase from one, then you should configure the number of parallel GC threads appropriately using -XX:ParallelGCThreads=N This message will then fail the test introduced in #20422 where we check if no entries have been added to the journal after the service has been started. This commit restore the default value for the `AssumeMP` option for CentOS and OracleServer. (cherry picked from commit 268d5ba)
tlrx
added a commit
that referenced
this pull request
Oct 24, 2016
Since with j`ava-1.8.0-openjdk-1.8.0.111-1.b15.el7_2.x86_64`, the OpenJDK packaged for CentOS and OEL override the default value (`false`) for the JVM option `AssumeMP` and force it to `true` (see [this patch](https://git.centos.org/blob/rpms!!java-1.8.0-openjdk.git/ab03fcc7a277355a837dd4c8500f8f90201ea353/SOURCES!always_assumemp.patch)) Because it is forced to true by default for these packages, the following warning message is printed to the standard output when the Vagrant box has only 1 CPU: > OpenJDK 64-Bit Server VM warning: If the number of processors is expected to increase from one, then you should configure the number of parallel GC threads appropriately using -XX:ParallelGCThreads=N This message will then fail the test introduced in #20422 where we check if no entries have been added to the journal after the service has been started. This commit restore the default value for the `AssumeMP` option for CentOS and OracleServer. (cherry picked from commit 268d5ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
-q/--quietoption to Elasticsearch so that it does not log anything in the console and closes stdout & stderr streams.This is useful for SystemD to avoid duplicate logs in both
journalctland/var/log/elasticsearch/elasticsearch.logwhile still allowing the JVM to print error messages in stdout/stderr if needed.Closes #17220
Related to #16159, #15315