Close InputStream when receiving cluster state in PublishClusterStateAction #22711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
:Distributed Coordination/Discovery-Plugins
bleskes
approved these changes
Jan 20, 2017
ywelsch
added a commit
that referenced
this pull request
Jan 20, 2017
…Action (#22711) Not closing the InputStream will leak native memory as the DeflateCompressor/Inflater won't be closed.
ywelsch
added a commit
that referenced
this pull request
Jan 20, 2017
…Action (#22711) Not closing the InputStream will leak native memory as the DeflateCompressor/Inflater won't be closed.
ywelsch
added a commit
that referenced
this pull request
Jan 20, 2017
…Action (#22711) Not closing the InputStream will leak native memory as the DeflateCompressor/Inflater won't be closed.
|
@bleskes We're hunting memory issues in Cloud, details on how this was found in https://github.com/elastic/dev/issues/715 |
|
@ywelsch This should have the 5.2.0 label. |
|
@jasontedor right! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not closing the InputStream will leak native memory as the DeflateCompressor/Inflater won't be closed.