[DOCS] Document minimum_should_match defaults for bool query
#48865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation for the `minimum_should_match` parameter to the `bool` query docs. Includes docs for the default values: - `1` if the `bool` query only includes `should` clauses - `0` if the `bool` query includes any other type of clauses
jrodewig
added
>docs
|
Pinging @elastic/es-search (:Search/Search) |
|
Pinging @elastic/es-docs (>docs) |
|
@jpountz Can you let me know what you think of these changes when convenient? Thank you! |
jpountz
reviewed
Dec 4, 2019
| percentage of `should` clauses returned documents _must_ match. | ||
|
|
||
| If the `bool` query includes only `should` clauses, the default value is `1`. | ||
| If the `bool` query includes any other type of clause, the default value is `0`. |
There was a problem hiding this comment.
It doesn't cover the case when a bool query includes should and must_not clauses, when the default value would still be 1. The below description would be closer to how we choose the default internally (I wish it was not that complicated).
If the `bool` query includes at least one `should` clause and no `must` or `filter` clauses, the default value is `1`.
Otherwise, the default value is `0`.
jpountz
approved these changes
Dec 4, 2019
|
when i use es7.1.1, only one should,but |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…stic#48865) Adds documentation for the `minimum_should_match` parameter to the `bool` query docs. Includes docs for the default values: - `1` if the `bool` query includes at least one `should` clause and no `must` or `filter` clauses - `0` otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for the
minimum_should_matchparameter to theboolquery docs. Includes docs for the default values:1if theboolquery only includesshouldclauses0if theboolquery includes any other type of clauses