Improve error message for non append-only writes that target data stream #60809
Conversation
martijnvg
added
>non-issue
v8.0.0
:Data Management/Data streams
|
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
There was a problem hiding this comment.
Thanks @martijnvg for fixing this, one small nit, otherwise LGTM
| infe.setResources("index_expression", indexExpressions); | ||
| if (excludedDataStreams) { | ||
| // Allows callers to handle IndexNotFoundException differently based on whether data streams were excluded. | ||
| infe.addMetadata("es.excluded_ds", "true"); |
There was a problem hiding this comment.
Maybe refactor es.excluded_ds to named constant?
| request.concreteIndex(indexNameExpressionResolver.concreteWriteIndex(clusterState, request).getName()); | ||
| } catch (IndexNotFoundException e) { | ||
| if (request.includeDataStreams() == false && e.getMetadataKeys().contains("es.excluded_ds")) { | ||
| throw new IllegalArgumentException("only write ops with op_type=create are allowed in data streams"); |
There was a problem hiding this comment.
| throw new IllegalArgumentException("only write ops with op_type=create are allowed in data streams"); | |
| throw new IllegalArgumentException("only write ops with an op_type of create are allowed in data streams"); |
| concreteIndex = indexNameExpressionResolver.concreteWriteIndex(state, request.indicesOptions(), | ||
| request.indices()[0], false, includeDataStreams); | ||
| } catch (IndexNotFoundException e) { | ||
| if (includeDataStreams == false && e.getMetadataKeys().contains("es.excluded_ds")) { |
There was a problem hiding this comment.
Just a question -- I don't understand why includeDataStreams == false is here. I would have thought it would be the opposite if it were addressing the case of indexing into data streams though it does seem to work according to the tests you added.
There was a problem hiding this comment.
I don't think it is needed (because es.excluded_ds is only set if includeDataStreams is false), but I like to keep it here to highlight that this check is only needed for op types other than create. If includeDataStreams is false then request.opType() is not CREATE.
…r_non_append_only_writes_targeting_ds
…eam (elastic#60874) Backport of elastic#60809 to 7.x branch. Closes elastic#60581
5 participants
When a write op with
op_typenot equal tocreatetargets a data streams then the following error is returned:no such index [null]. This isn't a meaningful error message. Also the the used exception (IndexNotFoundException) will result in a 404 response code.This PR adds exception handling logic, so that a
IllegalArgumentExceptionis returned with a better error message.This exception will return a 400 response code instead.
Closes #60581