Skip to content

[DOCS] Document discovery.seed_hosts only supports YAML collections #63746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2020
Merged

[DOCS] Document discovery.seed_hosts only supports YAML collections #63746

merged 5 commits into from
Oct 15, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Oct 15, 2020 •
edited
Loading

Explicitly documents that the discovery.seed_hosts setting only supports YAML collections.

Preview

https://elasticsearch_63746.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/discovery-settings.html

@jrodewig jrodewig added >docs General docs changes :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.0.0 v7.9.3 v7.11.0 v7.10.1 labels Oct 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Distributed)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team labels Oct 15, 2020
lockewritesdocs
lockewritesdocs approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good split on the examples. Thanks @jrodewig!

debadair
debadair approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@jrodewig jrodewig merged commit 9b8826c into elastic:master Oct 15, 2020
@jrodewig jrodewig deleted the docs__seed-hosts-yaml-collection branch October 15, 2020 20:28
This was referenced Oct 15, 2020
Merged
Merged
Merged
jrodewig added a commit that referenced this pull request Oct 15, 2020
@jrodewig
[DOCS] Document discovery.seed_hosts only supports YAML sequences a…
11d7937 
…nd arrays (#63746) (#63775)
jrodewig added a commit that referenced this pull request Oct 15, 2020
@jrodewig
[DOCS] Document discovery.seed_hosts only supports YAML sequences a…
da84622 
…nd arrays (#63746) (#63776)
jrodewig added a commit that referenced this pull request Oct 15, 2020
@jrodewig
[DOCS] Document discovery.seed_hosts only supports YAML sequences a…
eb6cd20 
…nd arrays (#63746) (#63777)
@andreidan andreidan added v7.10.0 and removed v7.10.1 labels Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddieturizo eddieturizo Awaiting requested review from eddieturizo

2 more reviewers

@debadair debadair debadair approved these changes

@lockewritesdocs lockewritesdocs lockewritesdocs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.9.3 v7.10.0 v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jrodewig @elasticmachine @debadair @lockewritesdocs @jakelandis @andreidan