Create async search index if necessary on updates and deletes #64606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change registers a template for the .async-search system index in order to ensure that deleting and re-creating the index outside of the async search API doesn't break the strict mapping.
jimczi
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
imotov
reviewed
Nov 6, 2020
...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/user/AsyncSearchUser.java
Outdated
Show resolved
Hide resolved
imotov
approved these changes
Nov 30, 2020
.../plugin/core/src/main/java/org/elasticsearch/xpack/core/async/AsyncTaskTemplateRegistry.java
Outdated
Show resolved
Hide resolved
jimczi
changed the title
|
@imotov , we discussed with @albertzaharovits and agreed that an index template is not needed. Instead, we ensure that the index is re-created when necessary on every operation (index, delete and update). We do the same for the security index so that's consistent. I updated the title, description and modified the PR to reflect the last discussions. Can you take another look ? |
imotov
approved these changes
Dec 1, 2020
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/async/AsyncTaskIndexService.java
Show resolved
Hide resolved
jimczi
added a commit
that referenced
this pull request
Dec 2, 2020
This change ensures that we create the async search index with the right mappings and settings when updating or deleting a document. Users can delete the async search index at any time so we have to re-create it internally if necessary before applying any new operation.
jimczi
added a commit
that referenced
this pull request
Dec 2, 2020
This change ensures that we create the async search index with the right mappings and settings when updating or deleting a document. Users can delete the async search index at any time so we have to re-create it internally if necessary before applying any new operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that we create the async search index with the right mappings and settings when updating or deleting a document. Users can delete the async search index at any time so we have to re-create it internally if necessary before applying any new operation.