Fix NPE in ClusterInfoService #65654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store stats can be `null` if e.g. the shard was already closed when the stats where retrieved. Don't record those shards in the sizes map to fix an NPE in this case.
original-brownbear
added
>non-issue
:Distributed Indexing/Distributed
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Jenkins run elasticsearch-ci/2 (already have a PR open for that failure) |
1 similar comment
|
Jenkins run elasticsearch-ci/2 (already have a PR open for that failure) |
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 1, 2020
Store stats can be `null` if e.g. the shard was already closed when the stats where retrieved. Don't record those shards in the sizes map to fix an NPE in this case.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 1, 2020
Store stats can be `null` if e.g. the shard was already closed when the stats where retrieved. Don't record those shards in the sizes map to fix an NPE in this case.
original-brownbear
added a commit
that referenced
this pull request
Dec 1, 2020
original-brownbear
added a commit
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store stats can be
nullif e.g. the shard was already closedwhen the stats where retrieved. Don't record those shards in the
sizes map to fix an NPE in this case that became visible as a result of #65415 now.