-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the Encrypted Repository behind a feature flag #65756
Merged
albertzaharovits
merged 10 commits into
elastic:repository-encrypted-client-side
from
albertzaharovits:repository-encrypted-feature-flag
Dec 23, 2020
Merged
Introduce the Encrypted Repository behind a feature flag #65756
albertzaharovits
merged 10 commits into
elastic:repository-encrypted-client-side
from
albertzaharovits:repository-encrypted-feature-flag
Dec 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
v7.11.0
:Security/Security
Security issues without another label
labels
Dec 2, 2020
Pinging @elastic/es-security (Team:Security) |
albertzaharovits
added
v8.0.0
and removed
Team:Security
Meta label for security team
v7.11.0
v8.0.0
labels
Dec 2, 2020
@elasticmachine test this please |
@elasticmachine update branch |
…itory-encrypted-feature-flag
albertzaharovits
force-pushed
the
repository-encrypted-feature-flag
branch
from
December 17, 2020 23:34
f346cf3
to
8047924
Compare
…itory-encrypted-feature-flag
tvernum
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…itory-encrypted-feature-flag
…itory-encrypted-feature-flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encrypted repository is usable to the extent that the feature can greatly benefit from testing as part of snapshot builds on cloud.
To get an impression of how to use this feature see the description of the last PR merged in the feature branch #53352 (comment) .
After this PR is merged to the feature branch, my plan is to raise the PR that merges the feature branch to master, without asking for any other reviews.