Enroll API to return CA cert using standard Base64 #75858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enroll API to return CA cert using standard Base64
BigPandaToo
added
>bug
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
jkakavas
approved these changes
Aug 2, 2021
albertzaharovits
approved these changes
Aug 3, 2021
In addition to that, I think we can remove the bug label and add non-issue as this is not a released feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enrollment APIs (Kibana and Node) should return certs
and keys encoded by standard Base64 encoding,
not the Url safe Base64 one.
PEM files require standard Base64 encoding, so using
safe Url encoding creates unnecessary complexity.
This change changes the encoding of the standard one.
Resolves #75781