Fix shell retry generator for shells other than bash #77422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>non-issue
:Delivery/Packaging
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/part-2 |
|
@elasticmachine update branch |
pugnascotia
changed the title
|
I took out the |
pugnascotia
added a commit
that referenced
this pull request
Sep 10, 2021
Closes #77414. The generated shell logic in ShellRetry doesn't work in more basic shells, so instead of using the {1..10} construct, expand the sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77414.
The generated shell logic in
ShellRetrydoesn't work in more basic shells, so insteadof using the
{1..10}construct, expand the sequence.