Skip to content

[ML] Log node selection during inference routing #88084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

[ML] Log node selection during inference routing #88084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...in/java/org/elasticsearch/xpack/ml/action/TransportInferTrainedModelDeploymentAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

package org.elasticsearch.xpack.ml.action;

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.elasticsearch.ElasticsearchStatusException;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.action.FailedNodeException;
Expand All @@ -32,12 +34,16 @@

import java.util.List;

import static org.elasticsearch.core.Strings.format;

public class TransportInferTrainedModelDeploymentAction extends TransportTasksAction<
TrainedModelDeploymentTask,
InferTrainedModelDeploymentAction.Request,
InferTrainedModelDeploymentAction.Response,
InferTrainedModelDeploymentAction.Response> {

private static final Logger logger = LogManager.getLogger(TransportInferTrainedModelDeploymentAction.class);

private final TrainedModelProvider provider;

@Inject
Expand Down Expand Up @@ -94,6 +100,7 @@ protected void doExecute(
listener.onFailure(ExceptionsHelper.conflictStatusException(message));
return;
}
logger.trace(() -> format("[%s] selecting node from routing table: %s", assignment.getModelId(), assignment.getNodeRoutingTable()));
String[] randomRunningNode = assignment.getStartedNodes();
if (randomRunningNode.length == 0) {
String message = "Trained model [" + deploymentId + "] is not allocated to any nodes";
Expand All @@ -102,6 +109,7 @@ protected void doExecute(
}
// TODO Do better routing for inference calls
int nodeIndex = Randomness.get().nextInt(randomRunningNode.length);
logger.trace(() -> format("[%s] selected node [%s]", assignment.getModelId(), randomRunningNode[nodeIndex]));
request.setNodes(randomRunningNode[nodeIndex]);
super.doExecute(task, request, listener);
}
Expand All @@ -118,6 +126,7 @@ protected InferTrainedModelDeploymentAction.Response newResponse(
} else if (failedNodeExceptions.isEmpty() == false) {
throw org.elasticsearch.ExceptionsHelper.convertToElastic(failedNodeExceptions.get(0));
} else if (tasks.isEmpty()) {
logger.trace(() -> format("[%s] unable to find deployment task for inference", request.getDeploymentId()));
throw new ElasticsearchStatusException(
"[{}] unable to find deployment task for inference please stop and start the deployment or try again momentarily",
RestStatus.NOT_FOUND,
Expand Down