Skip to content

[8.4] [ML] Improve reason when autoscaling capacity cannot be computed (#89316) #89320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2022
Merged

[8.4] [ML] Improve reason when autoscaling capacity cannot be computed (#89316) #89320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a3fd8
[ML] Improve reason when autoscaling capacity cannot be computed (#89…
dimitris-athanasiou Aug 12, 2022
88c4a1a
Merge branch '8.4' into backport/8.4/pr-89316
elasticmachine Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../ml/src/main/java/org/elasticsearch/xpack/ml/autoscaling/MlAutoscalingDeciderService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ public AutoscalingDeciderResult scale(Settings configuration, AutoscalingDecider
"view of job memory is stale given duration [{}]. Not attempting to make scaling decision",
mlMemoryTracker.getStalenessDuration()
);
return buildDecisionAndRequestRefresh(reasonBuilder);
return buildDecisionAndRequestRefresh(reasonBuilder.setSimpleReason(MEMORY_STALE));
}
// We need the current node loads to determine if we need to scale up or down
List<NodeLoad> nodeLoads = new ArrayList<>(mlNodes.size());
Expand Down Expand Up @@ -1163,7 +1163,7 @@ Optional<NativeMemoryCapacity> calculateFutureAvailableCapacity(PersistentTasksC

private AutoscalingDeciderResult buildDecisionAndRequestRefresh(MlScalingReason.Builder reasonBuilder) {
mlMemoryTracker.asyncRefresh();
return new AutoscalingDeciderResult(null, reasonBuilder.setSimpleReason(MEMORY_STALE).build());
return new AutoscalingDeciderResult(null, reasonBuilder.build());
}

private Long getAnalyticsMemoryRequirement(String analyticsId) {
Expand Down