[8.4] Empty intervals needs to start in position -1 (#89962) #89977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a match interval query ends up with no tokens after analysis, we return an IntervalsSource that produces an empty interval iterator. This empty iterator previously always reported its current doc id as NO_MORE_DOCS. However, unpositioned DocIdSetIterators should report their doc id as -1, so this broke the API contract, which could lead to exceptions when an empty interval query was combined in a conjunction. This commit fixes the empty interval implementation so that it returns -1 when unpositioned. Fixes elastic#89789
romseygeek
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.4: