Skip to content

Fix testFollowerBehaviour #96257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix testFollowerBehaviour #96257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9b6008
Fix testFollowerBehaviour
idegtiarenko May 22, 2023
72a9d9c
upd
idegtiarenko May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server/src/test/java/org/elasticsearch/cluster/coordination/LeaderCheckerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,14 @@ protected void onSendRequest(long requestId, String action, TransportRequest req
super.onSendRequest(requestId, action, request, node);

final boolean mustSucceed = leaderCheckRetryCount - 1 <= consecutiveFailedRequestsCount;
final long responseDelay = randomLongBetween(0, leaderCheckTimeoutMillis + (mustSucceed ? -1 : 60000));
final long responseDelay = randomValueOtherThan(
leaderCheckTimeoutMillis,
() -> randomLongBetween(0, leaderCheckTimeoutMillis + (mustSucceed ? -1 : 60000))
);
final boolean successResponse = allResponsesFail.get() == false && (mustSucceed || randomBoolean());

if (responseDelay >= leaderCheckTimeoutMillis) {
assert responseDelay != leaderCheckTimeoutMillis;
if (responseDelay > leaderCheckTimeoutMillis) {
timeoutCount.incrementAndGet();
consecutiveFailedRequestsCount += 1;
} else if (successResponse == false) {
Expand Down