Skip to content

Fix delay timeout in MockTransportService #97336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix delay timeout in MockTransportService #97336

merged 1 commit into from
Jul 3, 2023

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 3, 2023

We can pass an invalid duration to TimeValue, which accepts either -1 or an non-negative duration.

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Network Http and internode communication implementations auto-backport-and-merge v8.10.0 v8.9.1 v7.17.12 labels Jul 3, 2023
@dnhatn dnhatn requested a review from original-brownbear July 3, 2023 20:04
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 3, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

original-brownbear
original-brownbear approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@dnhatn
Copy link
Member Author

dnhatn commented Jul 3, 2023

Thanks Armin!

@dnhatn dnhatn added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 3, 2023
@elasticsearchmachine elasticsearchmachine merged commit 4d9e9ff into elastic:main Jul 3, 2023
@dnhatn dnhatn deleted the fix-delay-mock-transport-service branch July 3, 2023 20:48
@dnhatn dnhatn mentioned this pull request Jul 3, 2023
Merged
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jul 3, 2023
@dnhatn
Fix delay timeout in MockTransportService (elastic#97336)
19c05ad 
We can pass an invalid duration to TimeValue, which accepts either -1 or
an non-negative duration.
@dnhatn dnhatn mentioned this pull request Jul 3, 2023
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.9
✅ 7.17

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jul 3, 2023
@dnhatn
Fix delay timeout in MockTransportService (elastic#97336)
38eef4b 
We can pass an invalid duration to TimeValue, which accepts either -1 or
an non-negative duration.
elasticsearchmachine pushed a commit that referenced this pull request Jul 3, 2023
@dnhatn
Fix delay timeout in MockTransportService (#97336) (#97337)
3febf8c 
We can pass an invalid duration to TimeValue, which accepts either -1 or
an non-negative duration.
elasticsearchmachine pushed a commit that referenced this pull request Jul 3, 2023
@dnhatn
Fix delay timeout in MockTransportService (#97336) (#97338)
9bb69a2 
We can pass an invalid duration to TimeValue, which accepts either -1 or
an non-negative duration.
@rjernst rjernst added v8.9.0 and removed v8.9.1 labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@original-brownbear original-brownbear original-brownbear approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Network Http and internode communication implementations Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.17.12 v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticsearchmachine @original-brownbear @rjernst