-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Fix testILMDownsampleRollingRestart() test #98889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix testILMDownsampleRollingRestart() test #98889
Conversation
Check that source index exists prior to updating index.lifecycle.name index setting. Relates elastic#98764
Pinging @elastic/es-analytics-geo (Team:Analytics) |
// we need to attempt it in a assertBusy(...) | ||
assertBusy(() -> { | ||
try { | ||
if (indexExists(sourceIndex) == false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly this might happen in case there is a background downsample task running that failed for some reason, has been retried, and before we get here, the task completes right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. For example the request to update index settings fails to return because the node got shutdown, but the index settings were updated. The downsampling can be kicked off. When retrying the source index could not longer exist.
@elasticmachine update branch |
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample |
@elasticmachine update branch |
@elasticmachine update branch |
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
@elasticmachine update branch |
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
Check that source index exists prior to updating index.lifecycle.name index setting. Relates elastic#98764
Check that source index exists prior to updating index.lifecycle.name index setting.
Relates #98764