Skip to content

Conversation

martijnvg
Copy link
Member

Check that source index exists prior to updating index.lifecycle.name index setting.

Relates #98764

Check that source index exists prior to updating index.lifecycle.name index setting.

Relates elastic#98764
@martijnvg martijnvg added >test Issues or PRs that are addressing/adding tests :StorageEngine/Downsampling Downsampling (replacement for rollups) - Turn fine-grained time-based data into coarser-grained data v8.11.0 v8.10.1 labels Aug 25, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 25, 2023
// we need to attempt it in a assertBusy(...)
assertBusy(() -> {
try {
if (indexExists(sourceIndex) == false) {
Copy link
Contributor

@salvatore-campagna salvatore-campagna Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly this might happen in case there is a background downsample task running that failed for some reason, has been retried, and before we get here, the task completes right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. For example the request to update index settings fails to return because the node got shutdown, but the index settings were updated. The downsampling can be kicked off. When retrying the source index could not longer exist.

@martijnvg
Copy link
Member Author

@elasticmachine update branch

@martijnvg martijnvg added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 4, 2023
@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample

@martijnvg
Copy link
Member Author

@elasticmachine update branch

@martijnvg
Copy link
Member Author

@elasticmachine update branch

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample

@martijnvg
Copy link
Member Author

@elasticmachine update branch

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample

@elasticsearchmachine elasticsearchmachine merged commit 840cf5a into elastic:main Sep 6, 2023
@martijnvg martijnvg deleted the downsampel/fix_test/testILMDownsampleRollingRestart branch September 6, 2023 07:34
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Sep 6, 2023
Check that source index exists prior to updating index.lifecycle.name
index setting.

Relates elastic#98764
elasticsearchmachine pushed a commit that referenced this pull request Sep 6, 2023
Check that source index exists prior to updating index.lifecycle.name
index setting.

Relates #98764
@JVerwolf JVerwolf removed the v8.10.1 label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :StorageEngine/Downsampling Downsampling (replacement for rollups) - Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants