-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cisco_asa] fix visualizations #3146
Merged
leehinman
merged 1 commit into
elastic:main
from
leehinman:3142_cisco_asa_visualizations
Apr 21, 2022
Merged
[cisco_asa] fix visualizations #3146
leehinman
merged 1 commit into
elastic:main
from
leehinman:3142_cisco_asa_visualizations
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
bug
Something isn't working, use only for issues
Team:Security-External Integrations
labels
Apr 20, 2022
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
leehinman
force-pushed
the
3142_cisco_asa_visualizations
branch
from
April 20, 2022 17:56
7bf564c
to
844ee92
Compare
efd6
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after elastic-package build
- stop using `cisco.asa.message_id` in visualization - use data_stream to limit to cisco asa events - use event.code instead which has same info as `cisco.asa.message_id` did Closes elastic#3142
leehinman
force-pushed
the
3142_cisco_asa_visualizations
branch
from
April 21, 2022 14:09
844ee92
to
5d93e34
Compare
v1v
added a commit
to v1v/integrations
that referenced
this pull request
Apr 25, 2022
…ations into feature/labels-cloud-ephemeral-components * 'feature/labels-cloud-ephemeral-components' of github.com:v1v/integrations: (23 commits) use branch standardise labels/tags Update .ci/Jenkinsfile [ci][terraform][aws] tags with metadata Bump github.com/elastic/elastic-package from 0.46.0 to 0.47.0 (elastic#3182) Spring boot package [Memory - data stream] (elastic#2979) [cisco_ise] Add Cisco ISE package (elastic#2855) [apache_spark][executor] Add Apache Spark package with Executor data stream (elastic#2943) [apache_spark][driver] Add Apache Spark package with Driver data stream (elastic#2945) cisco_duo: simplify grok expression for handling ports (elastic#3170) cisco_duo: fix handling of IP addresses with port numbers (elastic#3117) [sophos] Various improvements and log samples from 18.5 (elastic#3127) [cisco_asa] fix visualizations (elastic#3146) [apache_spark][application] Add Apache Spark package with Application data stream (elastic#2941) Fix pagination bug that skipped events when more than one page is present. (elastic#3140) Cis k8s name migration (elastic#3113) remove exported fields; these will be added to Kibana docs instead (elastic#3093) Exclude ecosystem as owner of subdirectories of packages (elastic#3132) [awsfargate] bump package version (elastic#3130) add first csp rule template (elastic#3081) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cisco.asa.message_id
in visualization, field no longer populated.cisco.asa.message_id
didChecklist
changelog.yml
file.Related issues
Screenshots
Before
After