-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ceph] Add Integration Package with Cluster Health data stream #4963
[Ceph] Add Integration Package with Cluster Health data stream #4963
Conversation
/test |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I do not see dashboard specific files? Doesn't the datastream comes with visualisation ? |
The data stream does not have any visualization. Hence we haven't any dashboard specific files. |
Please use the actual docker image for creating system testcases. Reference : https://quay.io/repository/ceph/ceph?tab=tags, https://hub.docker.com/u/ceph, https://docs.ceph.com/en/latest/install/containers/ |
We already have gone through the ceph images which you have mentioned while doing system test. Also we have gone through the https://hub.docker.com/r/ceph/daemon image. We are facing this issue while doing docker-compose up, Also we have referred the ceph metricbeat module how they are doing system tests. So we have performed similar steps with our system test. But we are facing the issue related to API Secret Key. Hence we have to perform the system test using the mock server. |
@harnish-elastic , Can you please create an issue in the elastic-package repo explaining the requirement |
Raised issue in elastic-package repo explaining requirement. Link: elastic/elastic-package#1126 |
metric_type mapping is missing. Please add them. |
Updated, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…into package-ceph_cluster_health
…into package-ceph_cluster_health
Package ceph - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=ceph |
What does this PR do?
Checklist
How to test this PR locally
elastic-package test
Related issues